⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (e2fa8f8) to head (87f8411).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   88.45%   88.42%   -0.04%     
==========================================
  Files         116      117       +1     
  Lines        8611     8653      +42     
==========================================
+ Hits         7617     7651      +34     
- Misses        994     1002       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend It seems that when we use the arrow function we need strings for queries (not booleans or other types). I think that makes sense because querystring uses strings. If we change the data type to string in these tests, everything passes.

def test_arrow_where(self):
    """
    Make sure the arrow function can be used within a WHERE clause.
    """
    RecordingStudio(
        name="Abbey Road", facilities='{"mixing_desk": true}'
    ).save().run_sync()

    self.assertEqual(
        RecordingStudio.count()
        .where(RecordingStudio.facilities.arrow("mixing_desk").eq("true")) # <-- here
        .run_sync(),
        1,
    )

    self.assertEqual(
        RecordingStudio.count()
        .where(RecordingStudio.facilities.arrow("mixing_desk").eq("false")) # <-- here
        .run_sync(),
        0,
    )

I also removed the load json test because the output(load_json=True) doesn't return a boolean after new changes.

I hope that makes sense.

@sinisaos Thanks - you're right, the JSON values have to be strings.

@sinisaos Thanks. I went a bit crazy on this in the end.

You can now go multiple levels deep, and traverse array elements within the JSON.

await RecordingStudio.select(
    RecordingStudio.facilities["a"]["b"][0]["c"]
)

@dantownsend Wow! It's really amazing.

@sinisaos Thanks. It turned into a bigger thing than I expected. But with this, we can potentially do better JSON filtering in Piccolo Admin.